This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added TryExtendFromSelf
#1278
Merged
Added TryExtendFromSelf
#1278
+365
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
force-pushed
the
extend_from_self
branch
from
6273810 to
902078f
Compare
Codecov ReportBase: 83.02% // Head: 83.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
+ Coverage 83.02% 83.06% +0.04%
==========================================
Files 364 364
Lines 39136 39250 +114
==========================================
+ Hits 32491 32603 +112
- Misses 6645 6647 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This looks good! 👍 |
|
Can you also implement it for |
jorgecarleitao
force-pushed
the
extend_from_self
branch
from
902078f to
f91db92
Compare
I tried, but it is not so easy. I will split it into another issue/PR since it requires some trait thinking. |
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Nov 6, 2022
Added TryExtendFromSelf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a trait implemented for most mutable arrays that tells how a mutable array extends from itself,
fn try_extend_from_self(&mut self, other: &Self) -> Result<()>This also adds some functions that were missing in mutable counterparts to make it more idiomatic to write them (such as
Cloneandfrom).Closes #1268